Chore/lint and type events service #8342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
makelicious
commented
Jan 16, 2025
makelicious
commented
- Share lint rules between event client and backend
- Update events to match linting rules
- Update typescript to be the same as other services
- Refactor deduplication types to allow recursive definitions. Might prove helpful if we apply similar style for other parts of CC.
makelicious
requested review from
rikukissa and
jamil314
and removed request for
rikukissa
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
makelicious
added
the
🚀 Ready to deploy
github-actions
bot
temporarily deployed
to
chorelint-and-type-events-service
makelicious
temporarily deployed
to
chorelint-and-type-events-service
GitHub Actions
Inactive
makelicious
temporarily deployed
to
chorelint-and-type-events-service
GitHub Actions
Inactive
|
Your environment is deployed to https://chorelint-and-type-events-service.opencrvs.dev |
makelicious
deployed
to
chorelint-and-type-events-service
GitHub Actions
Active
jamil314
approved these changes
Jan 17, 2025
| @@ -121,7 +121,7 @@ export function seeder() { | |||
| id: createdUser.insertedId.toString() | |||
| } | |||
| } | |||
| const seedLocations = (db: Db, locations: Location[]) => | |||
| const seedLocations = async (db: Db, locations: Location[]) => | |||
| db.collection('locations').insertMany(locations) | |||
There was a problem hiding this comment.
Suggested change
| db.collection('locations').insertMany(locations) | |
| await db.collection('locations').insertMany(locations) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.